[
https://issues.apache.org/jira/browse/HDFS-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081062#comment-14081062
]
Yongjun Zhang commented on HDFS-6793:
-------------------------------------
Hi [[email protected]],
Thanks for the work here, I reviewed the latest patch and it looks good to me.
Couple of small suggestions, since this is for branch 2 ONLY (it should be
applied to both branch2 and branch2.5):
- since we don't expect jenkins test to pass on trunk, suggest to run a local
jenkins test against branch2 or branch2-5 with the change. or maybe you have
already done.
- it's better to have "branch-2" in the patch name, so it's easier for people
to see when looking at it in the future.
> Missing changes in HftpFileSystem when Reintroduce dfs.http.port /
> dfs.https.port in branch-2
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-6793
> URL: https://issues.apache.org/jira/browse/HDFS-6793
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Juan Yu
> Assignee: Juan Yu
> Attachments: HDFS-6793.patch, HDFS-6793.patch
>
>
> HDFS-6632 Reintroduce dfs.http.port / dfs.https.port in branch-2, but it
> doesn't include changes to HftpFileSystem.
> HftpFileSystem is removed from trunk, but still in 2.5, so in 2.5, we need to
> use dfs.http.port / dfs.https.port
--
This message was sent by Atlassian JIRA
(v6.2#6252)
