[
https://issues.apache.org/jira/browse/HDFS-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082823#comment-14082823
]
stack commented on HDFS-6803:
-----------------------------
Thank you mighty [[email protected]]
Makes sense. Recasting "2.1. Positional read and non-positional read can run
concurrently", and "2.2. Two or more positional reads can run concurrently" as
HDFS 'optimizations' is how we should high-level characterize these asserts.
Will make a patch for fsdatainputstream.md to do as you suggest along with
adding code and javadoc comment to DFSIS itself.
Sounds like you don't have problem with the asserts; you are just asking that
we categorize them properly and ensure we doc our expectations in the right
place (DFSIS is not enough).
Thanks
> Documenting DFSClient#DFSInputStream expectations reading and preading in
> concurrent context
> --------------------------------------------------------------------------------------------
>
> Key: HDFS-6803
> URL: https://issues.apache.org/jira/browse/HDFS-6803
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 2.4.1
> Reporter: stack
> Attachments: DocumentingDFSClientDFSInputStream (1).pdf
>
>
> Reviews of the patch posted the parent task suggest that we be more explicit
> about how DFSIS is expected to behave when being read by contending threads.
> It is also suggested that presumptions made internally be made explicit
> documenting expectations.
> Before we put up a patch we've made a document of assertions we'd like to
> make into tenets of DFSInputSteam. If agreement, we'll attach to this issue
> a patch that weaves the assumptions into DFSIS as javadoc and class comments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
