[
https://issues.apache.org/jira/browse/HDFS-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Liu updated HDFS-6817:
-------------------------
Attachment: HDFS-6817.002.patch
Thanks [~andrew.wang] and [~clamb] for the review. The new patch includes few
update about the synchronization.
I will commit to branch later. Charles, your suggestion about the loops
unrolled, loop makes code a bit clear, do you have concern about the
performance? I think it doesn’t matter.
Findbugs warnings are removed from my local build test.
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 38 new or
modified test files.
{color:red}-1 javac{color}. The applied patch generated 1263 javac compiler
warnings (more than the trunk's current 1260 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs
(version 2.0.1) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings.
> Fix findbugs and other warnings
> -------------------------------
>
> Key: HDFS-6817
> URL: https://issues.apache.org/jira/browse/HDFS-6817
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: security
> Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
> Reporter: Yi Liu
> Assignee: Yi Liu
> Priority: Minor
> Attachments: HDFS-6817.001.patch, HDFS-6817.002.patch
>
>
> We need to fix the findbugs and other warnings before merge.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
