[jira] [Commented] (HDFS-6582) Missing null check in RpcProgramNfs3#read(XDR, SecurityHandler)

[Abhiraj Butala (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087915#comment-14087915
 ] 

Abhiraj Butala commented on HDFS-6582:
--------------------------------------

The failures seem unrelated to the patch. These tests pass for me locally. 
There is some issue in cluster setup in automation:

{code}
Error Message

asf901.ygridcore.net: asf901.ygridcore.net
Stacktrace

java.net.UnknownHostException: asf901.ygridcore.net: asf901.ygridcore.net
        at java.net.InetAddress.getLocalHost(InetAddress.java:1402)
        at 
org.apache.hadoop.security.SecurityUtil.getLocalHostName(SecurityUtil.java:187)
        at org.apache.hadoop.security.SecurityUtil.login(SecurityUtil.java:207)
        at 
org.apache.hadoop.hdfs.server.datanode.DataNode.instantiateDataNode(DataNode.java:1936)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1337)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:728)
        at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:378)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:359)
        at org.apache.hadoop.hdfs.nfs.TestMountd.testStart(TestMountd.java:42)

{code}

> Missing null check in RpcProgramNfs3#read(XDR, SecurityHandler)
> ---------------------------------------------------------------
>
>                 Key: HDFS-6582
>                 URL: https://issues.apache.org/jira/browse/HDFS-6582
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>            Reporter: Ted Yu
>            Assignee: Abhiraj Butala
>            Priority: Minor
>         Attachments: HDFS-6582.patch
>
>
> Around line 691:
> {code}
>         FSDataInputStream fis = clientCache.getDfsInputStream(userName,
>             Nfs3Utils.getFileIdPath(handle));
>         try {
>           readCount = fis.read(offset, readbuffer, 0, count);
> {code}
> fis may be null, leading to NullPointerException



--
This message was sent by Atlassian JIRA
(v6.2#6252)