[
https://issues.apache.org/jira/browse/HDFS-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088496#comment-14088496
]
Aaron T. Myers commented on HDFS-6740:
--------------------------------------
The latest patch looks pretty good to me - pretty much just some simple
refactors to move some initialization code out of constructors and into methods
that could conceivably be called later. I agree that the test failures are
unrelated.
My only suggestion is to turn most of the instance variables in the new test
class into actual {{private static finals}}, since that's really what they are.
Also please convert those constants to be in UPPER_CASE instead of camelCase.
+1 once the above nits are addressed.
> FSDataset adds data volumes dynamically
> ---------------------------------------
>
> Key: HDFS-6740
> URL: https://issues.apache.org/jira/browse/HDFS-6740
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: 2.4.1
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HDFS-6740.000.patch
>
>
> To support volume management in DN (HDFS-1362), it requires FSDatasetImpl to
> be able to add volumes dynamically during runtime.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
