[
https://issues.apache.org/jira/browse/HDFS-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089903#comment-14089903
]
Hadoop QA commented on HDFS-6830:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12660426/HDFS-6830.02.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockInfo
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7583//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7583//console
This message is automatically generated.
> BlockManager.addStorage fails when DN updates storage
> -----------------------------------------------------
>
> Key: HDFS-6830
> URL: https://issues.apache.org/jira/browse/HDFS-6830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.5.0
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-6830.01.patch, HDFS-6830.02.patch
>
>
> The call to {{removeStorageInfo}} is wrong because the block is still in the
> DatanodeStorage's list of blocks and the callee does not expect it to be.
> {code}
> } else {
> // The block is on the DN but belongs to a different storage.
> // Update our state.
> removeStorage(getStorageInfo(idx));
> added = false; // Just updating storage. Return false.
> }
> {code}
> It is a very unlikely code path to hit since storage updates usually occur
> via incremental block reports.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
