[
https://issues.apache.org/jira/browse/HDFS-6828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090407#comment-14090407
]
Vinayakumar B commented on HDFS-6828:
-------------------------------------
Patch looks almost good.
Few nits here.
1. Typo {{datandoes}}.
{code}/** Dispatching block replica moves between datandoes. */{code}
2. Here {{Time.monotonicNow()}} could be used to escape from system time reset
issues. This is not the issue from the patch anyway.
{code}final long startTime = Time.now();{code}
and {code}if (Time.now() - startTime > MAX_ITERATION_TIME) {{code}
3. {{Dispatcher.shouldIgnore()}} need not be checked again in
{{Balancer#init(..)}}. {{Dispatcher#init(..)}} would have already excluded
decommission(ing/ed) nodes before calling {{Balancer#init(..)}}
4. Little javadoc about functioning of {{reduceNumOfRacks(..)}} would be better.
> Separate block replica dispatching from Balancer
> ------------------------------------------------
>
> Key: HDFS-6828
> URL: https://issues.apache.org/jira/browse/HDFS-6828
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h6828_20140808.patch, h6828_20140808b.patch
>
>
> The Balancer class implements two major features, (1) balancing logic for
> selecting replicas in order to balance the cluster and (2) block replica
> dispatching for moving the block replica around. This JIRA is to separate
> (2) from Balancer so that the code could be reused by other code such as the
> new data migration tool proposed in HDFS-6801.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
