[
https://issues.apache.org/jira/browse/HDFS-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091302#comment-14091302
]
Tsz Wo Nicholas Sze commented on HDFS-6830:
-------------------------------------------
I see. Thanks for the clarification.
+1 the new patch looks good.
> BlockInfo.addStorage fails when DN updates storage
> --------------------------------------------------
>
> Key: HDFS-6830
> URL: https://issues.apache.org/jira/browse/HDFS-6830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.5.0
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-6830.01.patch, HDFS-6830.02.patch,
> HDFS-6830.03.patch, HDFS-6830.04.patch
>
>
> The call to {{removeStorageInfo}} is wrong because the block is still in the
> DatanodeStorage's list of blocks and the callee does not expect it to be.
> {code}
> } else {
> // The block is on the DN but belongs to a different storage.
> // Update our state.
> removeStorage(getStorageInfo(idx));
> added = false; // Just updating storage. Return false.
> }
> {code}
> It is a very unlikely code path to hit since storage updates usually occur
> via incremental block reports.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
