[
https://issues.apache.org/jira/browse/HDFS-5887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096663#comment-14096663
]
Hadoop QA commented on HDFS-5887:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12661646/HDFS-5887.000.proto_files-only.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7633//console
This message is automatically generated.
> Add suffix to generated protobuf class
> --------------------------------------
>
> Key: HDFS-5887
> URL: https://issues.apache.org/jira/browse/HDFS-5887
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-5698 (FSImage in protobuf)
> Reporter: Haohui Mai
> Assignee: Tassapol Athiapinya
> Priority: Minor
> Attachments: HDFS-5887.000.patch, HDFS-5887.000.proto_files-only.patch
>
>
> As suggested by [~tlipcon], the code is more readable if we give each class
> generated by the protobuf the suffix "Proto".
> This jira proposes to rename the classes and to introduce no functionality
> changes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
