[
https://issues.apache.org/jira/browse/HDFS-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101516#comment-14101516
]
Jing Zhao commented on HDFS-6861:
---------------------------------
The patch looks pretty good to me. One minor comment is that maybe we can
remove Dispatcher#Source?
> Separate Balancer specific logic form Dispatcher
> ------------------------------------------------
>
> Key: HDFS-6861
> URL: https://issues.apache.org/jira/browse/HDFS-6861
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h6861_20140818.patch
>
>
> In order to balance datanode storage utilization of a cluster, Balancer (1)
> classifies datanodes into different groups (overUtilized, aboveAvgUtilized,
> belowAvgUtilized and underUtilized), (2) chooses source and target datanode
> pairs and (3) chooses blocks to move. Some of these logic are in Dispatcher.
> It is better to separate them out. This JIRA is a further work of HDFS-6828.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
