[
https://issues.apache.org/jira/browse/HDFS-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104004#comment-14104004
]
Hadoop QA commented on HDFS-6870:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12662752/HDFS-6870.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7692//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7692//console
This message is automatically generated.
> Blocks and INodes could leak for Rename with overwrite flag
> -----------------------------------------------------------
>
> Key: HDFS-6870
> URL: https://issues.apache.org/jira/browse/HDFS-6870
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HDFS-6870.001.patch
>
>
> Following code in FSDirectory#unprotectedRenameTo doesn't collect blocks and
> INodes for non snapshot path.
> {code}
> if (removedDst != null) {
> undoRemoveDst = false;
> if (removedNum > 0) {
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List<INode> removedINodes = new ChunkedArrayList<INode>();
> filesDeleted = removedDst.cleanSubtree(Snapshot.CURRENT_STATE_ID,
> dstIIP.getLatestSnapshotId(), collectedBlocks, removedINodes,
> true).get(Quota.NAMESPACE);
> getFSNamesystem().removePathAndBlocks(src, collectedBlocks,
> removedINodes, false);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
