[jira] [Commented] (HDFS-6886) Use single editlog record for creating file + overwrite.

[Vinayakumar B (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106518#comment-14106518
 ] 

Vinayakumar B commented on HDFS-6886:
-------------------------------------

I have one comment

{code}        if (overwrite) {
          // To remove a file, we need to check 'w' permission of parent
          checkParentAccess(pc, src, FsAction.WRITE);{code}
Here checking permission explicitly for delete not required. As its already 
would be checked here.
{code}    if (isPermissionEnabled) {
      if (overwrite && myFile != null) {
        checkPathAccess(pc, src, FsAction.WRITE);
      } else {
        checkAncestorAccess(pc, src, FsAction.WRITE);
      }
    }{code}

> Use single editlog record for creating file + overwrite.
> --------------------------------------------------------
>
>                 Key: HDFS-6886
>                 URL: https://issues.apache.org/jira/browse/HDFS-6886
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>            Priority: Critical
>         Attachments: HDFS-6886.001.patch, HDFS-6886.002.patch, editsStored
>
>
> As discussed in HDFS-6871, as [~jingzhao] and [~cmccabe]'s suggestion, we 
> could do further improvement to use one editlog record for creating file + 
> overwrite in this JIRA. We could record the overwrite flag in editlog for 
> creating file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)