[
https://issues.apache.org/jira/browse/HDFS-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112709#comment-14112709
]
Tsz Wo Nicholas Sze commented on HDFS-6944:
-------------------------------------------
Thanks for the update. Some minor comments on the new patch.
- Dispatcher.waitForMoveCompletion(..) may take Iterable<? extends
StorageGroup> as the parameter type. Then, change StorageGroupMap.iterator() to
{code}
public Collection<G> values() {
return map.values();
}
{code}
- In processChildrenList(..), it should return hasRemaining in the catch-block
since the directory may be partially listed.
- Let's also change Processor.chooseTarget(..) not to remove targetTypes.
Then, in processFile(..), change "diff.expected.size() > 0" to
"diff.expected.size() > 1".
- Please update the javadoc of StorageTypeDiff.removeOverlap().
> Archival Storage: add retry and termination logic for Mover
> -----------------------------------------------------------
>
> Key: HDFS-6944
> URL: https://issues.apache.org/jira/browse/HDFS-6944
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer, namenode
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-6944.000.patch, HDFS-6944.001.patch,
> HDFS-6944.002.patch, HDFS-6944.003.patch
>
>
> This jira plans to
> 1) add retry and termination logic for Mover,
> 2) add a testing framework for testing different scenarios of data migration.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
