[
https://issues.apache.org/jira/browse/HDFS-6831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113475#comment-14113475
]
Xiaoyu Yao commented on HDFS-6831:
----------------------------------
Attach a patch that fixed the issue with a commonUsageSummary string for both
commands and misc minor fixes.
* add the missing "-metasave filename"
* add the "Note: Administrative commands can only be run with superuser
permission.\n" to summary of PrintHelp() as Jing suggested.
* change "java DfsAdmin" to "hdfs DfsAdmin" in PrintUsage()
Not sure why quota and rolling upgrade commands have different for display
format with two "+" instead of "-" and extra spaces. I just keep it as is and
guess maybe it is to differentiate as new features.
"\t[" + SetQuotaCommand.USAGE + "]\n" +
> Inconsistency between 'hdfs dfsadmin' and 'hdfs dfsadmin -help'
> ---------------------------------------------------------------
>
> Key: HDFS-6831
> URL: https://issues.apache.org/jira/browse/HDFS-6831
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.4.0
> Reporter: Akira AJISAKA
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-6831.0.patch
>
>
> There is an inconsistency between the console outputs of 'hdfs dfsadmin'
> command and 'hdfs dfsadmin -help' command.
> {code}
> [root@trunk ~]# hdfs dfsadmin
> Usage: java DFSAdmin
> Note: Administrative commands can only be run as the HDFS superuser.
> [-report]
> [-safemode enter | leave | get | wait]
> [-allowSnapshot <snapshotDir>]
> [-disallowSnapshot <snapshotDir>]
> [-saveNamespace]
> [-rollEdits]
> [-restoreFailedStorage true|false|check]
> [-refreshNodes]
> [-finalizeUpgrade]
> [-rollingUpgrade [<query|prepare|finalize>]]
> [-metasave filename]
> [-refreshServiceAcl]
> [-refreshUserToGroupsMappings]
> [-refreshSuperUserGroupsConfiguration]
> [-refreshCallQueue]
> [-refresh]
> [-printTopology]
> [-refreshNamenodes datanodehost:port]
> [-deleteBlockPool datanode-host:port blockpoolId [force]]
> [-setQuota <quota> <dirname>...<dirname>]
> [-clrQuota <dirname>...<dirname>]
> [-setSpaceQuota <quota> <dirname>...<dirname>]
> [-clrSpaceQuota <dirname>...<dirname>]
> [-setBalancerBandwidth <bandwidth in bytes per second>]
> [-fetchImage <local directory>]
> [-shutdownDatanode <datanode_host:ipc_port> [upgrade]]
> [-getDatanodeInfo <datanode_host:ipc_port>]
> [-help [cmd]]
> {code}
> {code}
> [root@trunk ~]# hdfs dfsadmin -help
> hadoop dfsadmin performs DFS administrative commands.
> The full syntax is:
> hadoop dfsadmin
> [-report [-live] [-dead] [-decommissioning]]
> [-safemode <enter | leave | get | wait>]
> [-saveNamespace]
> [-rollEdits]
> [-restoreFailedStorage true|false|check]
> [-refreshNodes]
> [-setQuota <quota> <dirname>...<dirname>]
> [-clrQuota <dirname>...<dirname>]
> [-setSpaceQuota <quota> <dirname>...<dirname>]
> [-clrSpaceQuota <dirname>...<dirname>]
> [-finalizeUpgrade]
> [-rollingUpgrade [<query|prepare|finalize>]]
> [-refreshServiceAcl]
> [-refreshUserToGroupsMappings]
> [-refreshSuperUserGroupsConfiguration]
> [-refreshCallQueue]
> [-refresh <host:ipc_port> <key> [arg1..argn]
> [-printTopology]
> [-refreshNamenodes datanodehost:port]
> [-deleteBlockPool datanodehost:port blockpoolId [force]]
> [-setBalancerBandwidth <bandwidth>]
> [-fetchImage <local directory>]
> [-allowSnapshot <snapshotDir>]
> [-disallowSnapshot <snapshotDir>]
> [-shutdownDatanode <datanode_host:ipc_port> [upgrade]]
> [-getDatanodeInfo <datanode_host:ipc_port>
> [-help [cmd]
> {code}
> These two outputs should be the same.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
