[ 
https://issues.apache.org/jira/browse/HDFS-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114213#comment-14114213
 ] 

Konstantin Boudnik commented on HDFS-6940:
------------------------------------------

bq. I think it'd be much better if you could somehow abstract out the behavior 
of the NN that the ConsensusNode needs to change into some sort of plugin 
interface, with a default implementation just being what the NN currently does, 
and then you could provide an alternate implementation that does what the 
ConsensusNode needs to do.
If I am reading this right, you'd be ok with a potentially huge refactoring of 
NN followed by one the two:
 # significant duplication of the NN code in the CNode
 # unnecessarily exposing the implementation of many intimate parts of NN
Or would it acceptable to add a dynamic dependency injection mechanism, perhaps?

> Initial refactoring to allow ConsensusNode implementation
> ---------------------------------------------------------
>
>                 Key: HDFS-6940
>                 URL: https://issues.apache.org/jira/browse/HDFS-6940
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: HDFS-6940.patch
>
>
> Minor refactoring of FSNamesystem to open private methods that are needed for 
> CNode implementation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to