[
https://issues.apache.org/jira/browse/HDFS-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114523#comment-14114523
]
Andrew Wang commented on HDFS-6968:
-----------------------------------
Hi Zhe, patch looks basically good, just a few comments:
* put a small javadoc on the new {{repl}} variable
* As this is an optional flag, typically we enclose that with square brackets
in the help
* Would also be nice to update the documentation to match:
{noformat}
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/HadoopArchives.md.vm
{noformat}
+1 pending these
> Configurable replication degree in the hadoop archive command
> -------------------------------------------------------------
>
> Key: HDFS-6968
> URL: https://issues.apache.org/jira/browse/HDFS-6968
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: 2.6.0
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Priority: Minor
> Attachments: HDFS-6968.patch
>
>
> Due to be below hard-coded replication degree in {{HadoopArchives}}, the
> {{archive}} command will fail if HDFS maximum replication has already been
> configured to a number lower than 10.
> {code:java}
> //increase the replication of src files
> jobfs.setReplication(srcFiles, (short) 10);
> {code}
> This Jira will make the {{archive}} command configurable with desired
> replication degree.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
