[ 
https://issues.apache.org/jira/browse/HDFS-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115862#comment-14115862
 ] 

Andrew Wang commented on HDFS-6634:
-----------------------------------

Just one last nitty nit: could we use "{}" template strings for the new 
LOG.debug calls? This lets us avoid string construction overhead when DEBUG 
logging is off.

+1 pending, rest looks good.

> inotify in HDFS
> ---------------
>
>                 Key: HDFS-6634
>                 URL: https://issues.apache.org/jira/browse/HDFS-6634
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: hdfs-client, namenode, qjm
>            Reporter: James Thomas
>            Assignee: James Thomas
>         Attachments: HDFS-6634.2.patch, HDFS-6634.3.patch, HDFS-6634.4.patch, 
> HDFS-6634.5.patch, HDFS-6634.6.patch, HDFS-6634.7.patch, HDFS-6634.8.patch, 
> HDFS-6634.patch, inotify-design.2.pdf, inotify-design.3.pdf, 
> inotify-design.4.pdf, inotify-design.pdf, inotify-intro.2.pdf, 
> inotify-intro.pdf
>
>
> Design a mechanism for applications like search engines to access the HDFS 
> edit stream.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to