[
https://issues.apache.org/jira/browse/HDFS-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119140#comment-14119140
]
Colin Patrick McCabe commented on HDFS-6036:
--------------------------------------------
bq. The slf4j style uses {} as a template to avoid string concatenation, let's
make sure that's used for all the LOG calls.
ok
bq. shouldDefer, the !anchored case, could we lower the LOG to debug?
ok
bq. In UncachingTask#run, there's a little ternary to add "Deferred" before. We
could have it switch between "Deferred u" and "U" so the capitalization of
"Uncaching" is always correct.
I just added an 'if' statement, to avoid making this too complex :)
bq. The default is set to 15 hours, isn't this a really long time? I expected
something like a few mins.
Sorry, this was supposed to be 15 minutes. Fixed.
bq. New keys should be added to hdfs-default.xml as well.
added
bq. Regarding the minimum polling rate, I'd prefer to abort if it's not
configured correctly. Silent correction means bad conf values live a continued
existence, and confs get copy pasted around.
ok
bq. Having the min be revocation/2 is also somewhat arbitrary, but I'll go
along with it. Nyquist-ish?
Yeah, that was the motivation.
bq. It'd also be nice to print which client is holding on to anchors for too
long.
Yeah, very good idea. I implemented this...
> Forcibly timeout misbehaving DFSClients that try to do no-checksum reads that
> extend too long
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-6036
> URL: https://issues.apache.org/jira/browse/HDFS-6036
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: caching, datanode
> Affects Versions: 2.5.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-6036.001.patch
>
>
> We should forcibly timeout misbehaving DFSClients that try to do no-checksum
> reads that extend too long.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
