[ https://issues.apache.org/jira/browse/HDFS-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121933#comment-14121933 ]
Xiaoyu Yao commented on HDFS-6991: ---------------------------------- +1 with some minor issues in FsDataSetImpl.java line 2298: & should be && {code} while (iterations++ < MAX_BLOCK_EVICTIONS_PER_ITERATION & transientFreeSpaceBelowThreshold()) {code} line:2303: Log.info should be LOG.debug {code} if (LOG.isDebugEnabled()) { LOG.info("Evicting block " + replicaState); } {code} > Notify NN of evicted block before deleting it from RAM disk > ----------------------------------------------------------- > > Key: HDFS-6991 > URL: https://issues.apache.org/jira/browse/HDFS-6991 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Affects Versions: HDFS-6581 > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Attachments: HDFS-6991.01.patch, HDFS-6991.02.patch > > > When evicting a block from RAM disk to persistent storage, the DN should > notify the NN of the persistent replica before deleting the replica from RAM > disk. Else there can be a window of time during which the block is considered > 'missing' by the NN. > Found by [~xyao] via HDFS-6950. -- This message was sent by Atlassian JIRA (v6.3.4#6332)