[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125240#comment-14125240
]
Andrew Wang commented on HDFS-6951:
-----------------------------------
Overall looks good to me, just some test nits:
XAttrBaseTest
* It's a bit gross to have these {{expect == 3}} ifs. Can we instead refactor
so we pass in an array of xattrs we want to test?
* There's also a comment that says "Create two xattrs" which won't be right
anymore.
+1 pending these things though, thanks Charles.
> Saving namespace and restarting NameNode will remove existing encryption zones
> ------------------------------------------------------------------------------
>
> Key: HDFS-6951
> URL: https://issues.apache.org/jira/browse/HDFS-6951
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption
> Affects Versions: 3.0.0
> Reporter: Stephen Chu
> Assignee: Charles Lamb
> Attachments: HDFS-6951-prelim.002.patch, HDFS-6951-testrepo.patch,
> HDFS-6951.001.patch, HDFS-6951.002.patch, HDFS-6951.003.patch,
> HDFS-6951.004.patch, HDFS-6951.005.patch, HDFS-6951.006.patch, editsStored
>
>
> Currently, when users save namespace and restart the NameNode, pre-existing
> encryption zones will be wiped out.
> I could reproduce this on a pseudo-distributed cluster:
> * Create an encryption zone
> * List encryption zones and verify the newly created zone is present
> * Save the namespace
> * Kill and restart the NameNode
> * List the encryption zones and you'll find the encryption zone is missing
> I've attached a test case for {{TestEncryptionZones}} that reproduces this as
> well. Removing the saveNamespace call will get the test to pass.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
