[ 
https://issues.apache.org/jira/browse/HDFS-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127142#comment-14127142
 ] 

Daryn Sharp commented on HDFS-6660:
-----------------------------------

I believe this is an intermediate step, but by itself it appears to make things 
much worse.  The storage object ref is bring replaced with a boxed int for 
indirection into a map.  The boxed int ref is just as large as the direct 
storage ref it's replacing.  The map consumes a lot more memory too.  I think 
this patch should be based on one of the other subtasks.

Other than that, does the registration and add block logic need to be shifted 
between classes?  If it's an issue of being "cleaner", can you please make the 
change on another jira to make this patch more succinct?

(For future patches, please do not delete the prior patch.  It's very common to 
have multiple revisions of a patch on a jira)

> Use int instead of object reference to DatanodeStorageInfo in BlockInfo 
> triplets,
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-6660
>                 URL: https://issues.apache.org/jira/browse/HDFS-6660
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 2.4.1
>            Reporter: Amir Langer
>            Assignee: Amir Langer
>              Labels: performance
>         Attachments: HDFS-6660.patch
>
>
> Map an int index to every DatanodeStorageInfo and use it instead of object 
> reference in the BlockInfo triplets data structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to