[ 
https://issues.apache.org/jira/browse/HDFS-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Chu updated HDFS-6966:
------------------------------
    Attachment: HDFS-6966.4.patch

Hey [~andrew.wang], thanks a lot for the comments. I updated the patch to 
address them.

* Added double stars to javadoc the tests descriptions
* Assert true on the successful rename test case
* Add verification that the contents read from snapshotted encrypted file are 
as expected
* Add reading file contents after failover to make sure they're the same
* It turns out that the KeyProvider of both the NNs in the HA test are not the 
same object (fails ==). I couldn't find a good way to set them to be the same 
object, so I changed DFSTestUtil to allow creating a key while specifying a NN 
index and created the same key for both the NameNodes. Let me know if you think 
there's a better way.
* Set the client's provider to NN0's KeyProvider.

> Add additional unit tests for encryption zones
> ----------------------------------------------
>
>                 Key: HDFS-6966
>                 URL: https://issues.apache.org/jira/browse/HDFS-6966
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption
>    Affects Versions: 3.0.0, 2.6.0
>            Reporter: Stephen Chu
>            Assignee: Stephen Chu
>         Attachments: HDFS-6966.1.patch, HDFS-6966.2.patch, HDFS-6966.3.patch, 
> HDFS-6966.4.patch
>
>
> There are some more unit tests that can be added for test encryption zones. 
> For example, more encryption zone + snapshot tests, running fsck on 
> encryption zones, and more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to