[ 
https://issues.apache.org/jira/browse/HDFS-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132251#comment-14132251
 ] 

Kihwal Lee commented on HDFS-7046:
----------------------------------

Replaying last edit segment won't take much time anyway. So even if the 
decision for leaving safe mode is made in the middle, it will still have to 
wait more than 20 seconds in safe mode extension. So I don't think the 
suggested change will help much.  If a user really cares about failover 
latency, the safe mode extension should be set to 0 or a very small value.

> HA NN can NPE upon transition to active
> ---------------------------------------
>
>                 Key: HDFS-7046
>                 URL: https://issues.apache.org/jira/browse/HDFS-7046
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.5.0
>            Reporter: Daryn Sharp
>            Assignee: Kihwal Lee
>            Priority: Critical
>         Attachments: HDFS-7046.patch, HDFS-7046_test_reproduce.patch
>
>
> While processing edits, the NN may decide after adjusting block totals to 
> leave safe mode - in the middle of the edit.  Going active starts the secret 
> manager which generates a new secret key, which in turn generates an edit, 
> which NPEs because the edit log is not open.
> # Transitions should _not_ occur in the middle of an edit.
> # The edit log appears to claim it's open for write when the stream isn't 
> even open



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to