[
https://issues.apache.org/jira/browse/HDFS-6843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133612#comment-14133612
]
Andrew Wang commented on HDFS-6843:
-----------------------------------
I looked through the patch assuming that FsPermissionExtension hasn't changed.
Only review comment:
* In the test, it seems we could extract a function, and run the function with
the normal base path, then with the /.r/r base path. Save some lines? If you
put the path being tested in the assert message, we don't lose any info.
+1 pending this and Jenkins, thanks Charles.
> Create FileStatus isEncrypted() method
> --------------------------------------
>
> Key: HDFS-6843
> URL: https://issues.apache.org/jira/browse/HDFS-6843
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode, security
> Affects Versions: 3.0.0
> Reporter: Charles Lamb
> Assignee: Charles Lamb
> Attachments: HDFS-6843.001.patch, HDFS-6843.002.patch,
> HDFS-6843.003.patch, HDFS-6843.004.patch, HDFS-6843.005.patch,
> HDFS-6843.005.patch, HDFS-6843.006.patch
>
>
> FileStatus should have a 'boolean isEncrypted()' method. (it was in the
> context of discussing with AndreW about FileStatus being a Writable).
> Having this method would allow MR JobSubmitter do the following:
> -----
> BOOLEAN intermediateEncryption = false
> IF jobconf.contains("mr.intermidate.encryption") THEN
> intermediateEncryption = jobConf.getBoolean("mr.intermidate.encryption")
> ELSE
> IF (I/O)Format INSTANCEOF File(I/O)Format THEN
> intermediateEncryption = ANY File(I/O)Format HAS a Path with status
> isEncrypted()==TRUE
> FI
> jobConf.setBoolean("mr.intermidate.encryption", intermediateEncryption)
> FI
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
