[
https://issues.apache.org/jira/browse/HDFS-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138208#comment-14138208
]
Aaron T. Myers commented on HDFS-6727:
--------------------------------------
The latest patch looks pretty darn good to me, and I agree with the direction
change that Colin suggested. I have just a few small comments, +1 once these
are addressed and the findbugs comes back clean. I'm pretty sure the failed
tests are unrelated to this change - they all passed locally on my box with
this patch applied.
# Since the new "-hotswap" constant cannot actually be used as a startup
option, I recommend adding a comment to that effect where it's declared. Longer
term I think we should actually do away with this as part of the
{{StartupOption}} enum entirely, but you can certainly do that as a separate
JIRA.
# Recommend making {{parseChangedVolumes}} return a little two-member class,
instead of a list of two elements. Seems a little cleaner that way.
# Is the change to {{FsDatasetImpl#invalidate}} to add the call to
{{notifyNamenodeDeletedBlock}} a separate bug? Or how is it related to this
change? I'm surprised that needed to be done.
# I think you may have missed [~cmccabe]'s comment about "Let's change this to
not throw IOException. It's confusing to have both a return value of the
volumes that we successfully added and an IOE. I would pick one... just the
list of volumes."
> Refresh data volumes on DataNode based on configuration changes
> ---------------------------------------------------------------
>
> Key: HDFS-6727
> URL: https://issues.apache.org/jira/browse/HDFS-6727
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: 2.5.0, 2.4.1
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Labels: datanode
> Attachments: HDFS-6727.000.delta-HDFS-6775.txt, HDFS-6727.001.patch,
> HDFS-6727.002.patch, HDFS-6727.003.patch, HDFS-6727.004.patch,
> HDFS-6727.005.patch, HDFS-6727.combo.patch
>
>
> HDFS-1362 requires DataNode to reload configuration file during the runtime,
> so that DN can change the data volumes dynamically. This JIRA reuses the
> reconfiguration framework introduced by HADOOP-7001 to enable DN to
> reconfigure at runtime.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
