[
https://issues.apache.org/jira/browse/HDFS-6808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139628#comment-14139628
]
Colin Patrick McCabe commented on HDFS-6808:
--------------------------------------------
Looks good overall.
{code}
// A map of <changed property, error message>. If error message is present,
// it contains the messages about the error occurred when applies the
particular
// change. Otherwise, it indicates that the change has been successfully
applied.
private Map<PropertyChange, Optional<String>> status = null;
{code}
This still needs to be JavaDoc'ed. Similar with reconfigThread.
ReconfigurationThread needs to call {{setDaemon}} and also set its name for
jstack purposes.
{code}
/**
* Asynchronously reload configuration on disk and apply changes.
*/
void startReconfigure() throws IOException;
{code}
Rename to {{startReconfiguration}}?
{code}
/**
* Get the status of the previously issued reconfig task.
* @see {@link
org.apache.hadoop.conf.ReconfigurableBase.ReconfigurationTaskStatus}.
*/
ReconfigurableBase.ReconfigurationTaskStatus getReconfigureStatus() throws
IOException;
{code}
Can you make {{ReconfigurationTaskStatus}} a top-level class? Normally return
values from RPCs are either top-level classes, or static inner classes defined
in the interface file itself.
{{DFSAdmin.java}}: does this print anything when starting a reconfiguration?
It would be nice to print something like "Started reconfiguration on NameNode
127.0.0.1."
{code}
message GetReconfigurationStatusConfigChangeProto {
required string name = 1;
{code}
How about calling this "key" to be more consistent with our other config stuff?
> Add command line option to ask DataNode reload configuration.
> -------------------------------------------------------------
>
> Key: HDFS-6808
> URL: https://issues.apache.org/jira/browse/HDFS-6808
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: 2.5.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HDFS-6808.000.combo.patch, HDFS-6808.000.patch,
> HDFS-6808.001.combo.patch, HDFS-6808.001.patch, HDFS-6808.002.combo.patch,
> HDFS-6808.002.patch, HDFS-6808.003.combo.txt, HDFS-6808.003.patch,
> HDFS-6808.004.combo.patch, HDFS-6808.004.patch, HDFS-6808.005.combo.patch,
> HDFS-6808.005.patch, HDFS-6808.006.combo.patch, HDFS-6808.006.patch,
> HDFS-6808.007.combo.patch, HDFS-6808.007.patch, HDFS-6808.008.combo.patch,
> HDFS-6808.008.patch
>
>
> The workflow of dynamically changing data volumes on DataNode is
> # Users manually changed {{dfs.datanode.data.dir}} in the configuration file
> # User use command line to notify DN to reload configuration and updates its
> volumes.
> This work adds command line support to notify DN to reload configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
