[
https://issues.apache.org/jira/browse/HDFS-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140088#comment-14140088
]
Akira AJISAKA commented on HDFS-7049:
-------------------------------------
bq. Looks like Hadoop QA tried to apply the patch to trunk,
Yes, Hadoop QA always tests the patch on trunk.
+1 (non-binding). The test code is the same as trunk, and the test passed on my
environment.
[~wheat9], would you please review the patch?
> TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
> ----------------------------------------------------------------------------
>
> Key: HDFS-7049
> URL: https://issues.apache.org/jira/browse/HDFS-7049
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.5.0
> Reporter: Juan Yu
> Assignee: Juan Yu
> Priority: Minor
> Attachments: HDFS-7049-branch-2.002.patch, HDFS-7049-branch-2.patch
>
>
> On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when
> HftpFileSystem$RangeHeaderUrlOpener.connect
> This is due to fix of HDFS-6143 "WebHdfsFileSystem open should throw
> FileNotFoundException for non-existing paths"
> public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException {
> this.originalURL = o;
> this.resolvedURL = r;
> getInputStream();
> }
> the getInputStream() will be called in constructor now to verify if file
> exists.
> Since we just try to test if ByteRangeInputStream#close is called at proper
> time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for
> testing to avoid the NPE issue.
> I believe the trunk version already does this, we just need to merge the test
> from trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
