[
https://issues.apache.org/jira/browse/HDFS-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145627#comment-14145627
]
Colin Patrick McCabe commented on HDFS-7055:
--------------------------------------------
bq. Nit: This exception, if it possible to ask trace for the list of options,
should list the possible options (I can see folks typing in sampler with wrong
case or missing a piece... listing possible options will allow them quickly see
what they have done wrong):
yeah, will add
bq. Nit: Should we have a convention naming spans Colin Patrick McCabe? For
example, method name followed by arg types all in camel case?
readByteArrayIntInt
I'm not sure about naming them according to function calls, since function
calls do change over time. Also, functions like "public int read(long
position, byte[] buffer, int offset, int length)" will start to look like
"Vogon poetry" if we make them into "readLongByteArrayIntInt".
"positionalByteArrayRead" seems a lot clearer to me, and emphasizes the fact
that it includes a "seek." Maybe it makes sense to add a class prefix (like
{{DFSInputStream#positionalByteArrayRead}}?) I think we should discuss span
naming in a follow-up JIRA down the line, once we get all this stuff in.
bq. Patch looks great to me. You gotten any spans out of it? I can try it if
you'd like, no problem.
Yeah, I did some testing with the local file sink. My configuration is here:
https://github.com/cmccabe/hadoop-conf/tree/trace
> Add tracing to DFSInputStream
> -----------------------------
>
> Key: HDFS-7055
> URL: https://issues.apache.org/jira/browse/HDFS-7055
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 2.6.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-7055.002.patch
>
>
> Add tracing to DFSInputStream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
