[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-7118:
--------------------------------
Resolution: Fixed
Fix Version/s: 2.6.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thank you for the code review, Suresh. I committed this to trunk and branch-2.
> Improve diagnostics on storage directory rename operations by using
> NativeIO#renameTo in Storage#rename.
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-7118
> URL: https://issues.apache.org/jira/browse/HDFS-7118
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: journal-node, namenode
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Fix For: 2.6.0
>
> Attachments: HDFS-7118.1.patch
>
>
> If a file rename fails, {{NativeIO#renameTo}} includes more information about
> the root cause than a plain {{java.io.File#renameTo}}. The native code can
> throw an exception with a detailed error message and the {{errno}} on *nix or
> the value of {{GetLastError}} on Windows. This issue proposes to use
> {{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
> improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
> native code is not loaded, so this change would not introduce a compatibility
> problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
