[ 
https://issues.apache.org/jira/browse/HDFS-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148258#comment-14148258
 ] 

Hadoop QA commented on HDFS-7077:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12671270/hdfs-7077.005.patch
  against trunk revision dc2ebf8.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.crypto.random.TestOsSecureRandom
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots
                  org.apache.hadoop.fs.TestUrlStreamHandler
                  org.apache.hadoop.hdfs.server.namenode.TestFileLimit
                  org.apache.hadoop.hdfs.server.namenode.TestEditLogAutoroll
                  org.apache.hadoop.TestRefreshCallQueue
                  org.apache.hadoop.hdfs.protocolPB.TestPBHelper
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
                  org.apache.hadoop.cli.TestCryptoAdminCLI
                  org.apache.hadoop.hdfs.server.datanode.TestDiskError
                  org.apache.hadoop.fs.viewfs.TestViewFsWithAcls
                  
org.apache.hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
                  org.apache.hadoop.hdfs.server.namenode.TestFSEditLogLoader
                  org.apache.hadoop.hdfs.server.namenode.TestHostsFiles
                  org.apache.hadoop.hdfs.server.datanode.TestTransferRbw
                  org.apache.hadoop.fs.contract.hdfs.TestHDFSContractDelete
                  org.apache.hadoop.hdfs.server.namenode.TestFileContextAcl
                  org.apache.hadoop.fs.TestFcHdfsSetUMask
                  org.apache.hadoop.hdfs.server.namenode.TestClusterId
                  org.apache.hadoop.hdfs.server.namenode.TestDeleteRace
                  org.apache.hadoop.hdfs.server.namenode.TestFSDirectory
                  org.apache.hadoop.hdfs.server.namenode.TestLeaseManager
                  org.apache.hadoop.fs.contract.hdfs.TestHDFSContractOpen
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing
                  org.apache.hadoop.hdfs.server.datanode.TestStorageReport
                  org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery
                  org.apache.hadoop.fs.contract.hdfs.TestHDFSContractMkdir
                  org.apache.hadoop.fs.contract.hdfs.TestHDFSContractAppend
                  org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache
                  
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
                  org.apache.hadoop.hdfs.server.namenode.ha.TestQuotasWithHA
                  org.apache.hadoop.hdfs.server.namenode.ha.TestGetGroupsWithHA
                  org.apache.hadoop.hdfs.server.namenode.TestSecondaryWebUi
                  org.apache.hadoop.hdfs.server.namenode.TestAuditLogger
                  org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat
                  org.apache.hadoop.hdfs.server.datanode.TestCachingStrategy
                  org.apache.hadoop.hdfs.server.namenode.TestAddBlockRetry
                  org.apache.hadoop.fs.TestSymlinkHdfsFileSystem
                  org.apache.hadoop.fs.viewfs.TestViewFsDefaultValue
                  org.apache.hadoop.fs.TestSymlinkHdfsFileContext
                  org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
                  org.apache.hadoop.hdfs.TestFSInputChecker
                  org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
                  org.apache.hadoop.hdfs.server.datanode.TestDataNodeInitStorage
                  org.apache.hadoop.hdfs.server.mover.TestStorageMover
                  org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling
                  
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol
                  org.apache.hadoop.cli.TestAclCLI
                  org.apache.hadoop.hdfs.server.namenode.ha.TestHAMetrics
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
                  org.apache.hadoop.hdfs.server.namenode.TestFsLimits
                  
org.apache.hadoop.hdfs.server.datanode.TestReadOnlySharedStorage
                  org.apache.hadoop.hdfs.TestEncryptedTransfer
                  
org.apache.hadoop.hdfs.server.namenode.TestNNStorageRetentionFunctional
                  org.apache.hadoop.hdfs.server.datanode.TestHSync
                  org.apache.hadoop.hdfs.server.namenode.TestNameNodeRpcServer
                  org.apache.hadoop.fs.contract.hdfs.TestHDFSContractSeek
                  org.apache.hadoop.hdfs.server.namenode.TestFileContextXAttr
                  org.apache.hadoop.hdfs.server.namenode.TestAclConfigFlag
                  org.apache.hadoop.hdfs.server.namenode.TestSequentialBlockId
                  org.apache.hadoop.hdfs.server.namenode.TestFSImageWithXAttr
                  
org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot
                  org.apache.hadoop.hdfs.server.namenode.TestFSImageWithAcl
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
                  org.apache.hadoop.tracing.TestTracing
                  
org.apache.hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
                  org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
                  
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
                  org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
                  
org.apache.hadoop.hdfs.server.namenode.TestNameNodeResourceChecker
                  org.apache.hadoop.hdfs.server.namenode.TestGenericJournalConf
                  org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs
                  org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit
                  
org.apache.hadoop.hdfs.server.namenode.TestEditLogJournalFailures
                  org.apache.hadoop.hdfs.TestPersistBlocks
                  org.apache.hadoop.hdfs.TestDatanodeReport
                  org.apache.hadoop.tools.TestJMXGet
                  org.apache.hadoop.hdfs.server.namenode.TestNameNodeMXBean
                  
org.apache.hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
                  org.apache.hadoop.fs.contract.hdfs.TestHDFSContractCreate
                  
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
                  org.apache.hadoop.hdfs.server.namenode.TestCreateEditsLog
                  org.apache.hadoop.hdfs.server.namenode.TestFSNamesystemMBean
                  org.apache.hadoop.hdfs.TestWriteRead
                  
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
                  
org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation
                  org.apache.hadoop.fs.TestEnhancedByteBufferAccess
                  org.apache.hadoop.fs.TestFcHdfsPermission
                  org.apache.hadoop.hdfs.server.namenode.TestEditLogRace
                  org.apache.hadoop.security.TestRefreshUserMappings
                  org.apache.hadoop.hdfs.server.namenode.TestAllowFormat
                  org.apache.hadoop.fs.viewfs.TestViewFsHdfs
                  org.apache.hadoop.fs.TestResolveHdfsSymlink
                  
org.apache.hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
                  
org.apache.hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
                  
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestWriteToReplica
                  org.apache.hadoop.tracing.TestTracingShortCircuitLocalRead
                  
org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
                  org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer
                  
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics
                  
org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
                  org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS
                  org.apache.hadoop.hdfs.server.namenode.TestINodeFile
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
                  
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
                  org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
                  org.apache.hadoop.hdfs.server.balancer.TestBalancer
                  org.apache.hadoop.fs.TestFcHdfsCreateMkdir
                  org.apache.hadoop.hdfs.server.namenode.ha.TestNNHealthCheck
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters
                  org.apache.hadoop.hdfs.TestLeaseRenewer
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
                  
org.apache.hadoop.hdfs.server.namenode.TestBlockUnderConstruction
                  org.apache.hadoop.hdfs.server.mover.TestMover
                  org.apache.hadoop.hdfs.server.namenode.TestDeadDatanode
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
                  
org.apache.hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
                  org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
                  
org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports
                  
org.apache.hadoop.hdfs.server.namenode.TestCommitBlockSynchronization
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled
                  org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
                  org.apache.hadoop.hdfs.server.namenode.TestFSNamesystem
                  org.apache.hadoop.hdfs.server.namenode.TestEditLog
                  org.apache.hadoop.fs.viewfs.TestViewFileSystemWithXAttrs
                  org.apache.hadoop.hdfs.server.namenode.ha.TestHAFsck
                  org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls
                  org.apache.hadoop.hdfs.server.namenode.TestXAttrConfigFlag
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot
                  
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
                  
org.apache.hadoop.hdfs.server.namenode.TestNameNodeRespectsBindHostKeys
                  org.apache.hadoop.hdfs.server.datanode.TestDataNodeMXBean
                  org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
                  org.apache.hadoop.hdfs.server.namenode.TestSnapshotPathINodes
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestStateTransitionFailure
                  org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
                  org.apache.hadoop.security.TestPermission
                  
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
                  org.apache.hadoop.fs.contract.hdfs.TestHDFSContractConcat
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
                  org.apache.hadoop.hdfs.server.namenode.ha.TestHAConfiguration
                  org.apache.hadoop.hdfs.server.namenode.TestFSPermissionChecker
                  
org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestDFSZKFailoverController
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
                  org.apache.hadoop.hdfs.server.namenode.TestFsck
                  org.apache.hadoop.hdfs.server.namenode.TestAuditLogs
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestHostFileManager
                  
org.apache.hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade
                  org.apache.hadoop.security.TestPermissionSymlinks
                  
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
                  org.apache.hadoop.net.TestNetworkTopology
                  
org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
                  org.apache.hadoop.cli.TestXAttrCLI
                  org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs
                  org.apache.hadoop.hdfs.TestEncryptionZonesWithHA
                  org.apache.hadoop.hdfs.server.datanode.TestRefreshNamenodes
                  org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
                  org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRename
                  
org.apache.hadoop.hdfs.server.namenode.TestSecurityTokenEditLog
                  org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
                  
org.apache.hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
                  org.apache.hadoop.fs.permission.TestStickyBit
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
                  org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotManager
                  org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot
                  org.apache.hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot
                  org.apache.hadoop.hdfs.server.namenode.TestTransferFsImage
                  org.apache.hadoop.hdfs.server.namenode.TestStartup
                  org.apache.hadoop.hdfs.server.namenode.TestNameNodeRecovery
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover
                  
org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
                  org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
                  
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
                  
org.apache.hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
                  org.apache.hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
                  org.apache.hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
                  org.apache.hadoop.hdfs.TestPipelines
                  org.apache.hadoop.fs.loadGenerator.TestLoadGenerator
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename
                  org.apache.hadoop.cli.TestCacheAdminCLI
                  
org.apache.hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
                  
org.apache.hadoop.hdfs.server.namenode.TestMetadataVersionOutput
                  
org.apache.hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler
                  org.apache.hadoop.fs.TestHDFSFileContextMainOperations
                  org.apache.hadoop.hdfs.server.namenode.TestSaveNamespace
                  
org.apache.hadoop.hdfs.server.datanode.TestMultipleNNDataBlockScanner
                  org.apache.hadoop.fs.TestGlobPaths
                  org.apache.hadoop.fs.viewfs.TestViewFsFileStatusHdfs
                  org.apache.hadoop.hdfs.server.namenode.TestMetaSave
                  
org.apache.hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestPendingReplication
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA
                  org.apache.hadoop.fs.viewfs.TestViewFsAtHdfsRoot
                  org.apache.hadoop.TestGenericRefresh
                  
org.apache.hadoop.hdfs.server.datanode.TestIncrementalBrVariations
                  
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer
                  org.apache.hadoop.hdfs.server.namenode.ha.TestHAAppend
                  org.apache.hadoop.hdfs.server.namenode.TestBackupNode
                  org.apache.hadoop.hdfs.server.namenode.TestNameNodeAcl
                  
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
                  org.apache.hadoop.fs.shell.TestHdfsTextCommand
                  org.apache.hadoop.cli.TestHDFSCLI
                  org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure
                  
org.apache.hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd
                  org.apache.hadoop.fs.TestSymlinkHdfsDisable
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
                  org.apache.hadoop.hdfs.server.namenode.TestFSImage
                  org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs
                  org.apache.hadoop.hdfs.server.namenode.TestAddBlock
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
                  org.apache.hadoop.hdfs.TestDFSInotifyEventInputStream
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot
                  org.apache.hadoop.hdfs.server.namenode.TestNameNodeXAttr
                  
org.apache.hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold
                  org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean
                  org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing
                  
org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade

                                      The following test timeouts occurred in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.util.TestMachineList
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/8206//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/8206//artifact/PreCommit-HADOOP-Build-patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8206//console

This message is automatically generated.

> Separate CipherSuite from crypto protocol version
> -------------------------------------------------
>
>                 Key: HDFS-7077
>                 URL: https://issues.apache.org/jira/browse/HDFS-7077
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption
>    Affects Versions: 2.6.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-7077.001.patch, hdfs-7077.002.patch, 
> hdfs-7077.003.patch, hdfs-7077.004.patch, hdfs-7077.005.patch
>
>
> Right now the CipherSuite is used for protocol version negotiation, which is 
> wrong. We need to separate it out. An EZ should be locked to a certain 
> CipherSuite and protocol version. A client reading and writing to the EZ then 
> needs to negotiate based on both of these parameters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to