[ 
https://issues.apache.org/jira/browse/HDFS-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152010#comment-14152010
 ] 

Colin Patrick McCabe commented on HDFS-7162:
--------------------------------------------

Good find.

Rather than doing as this patch does, it would be better to add a slash to the 
end of {{trash_base}}.  That way, this check would not be triggered for paths 
which were not actually in Current:

{code}
  if (!strncmp(trash_base, abs_path, strlen(trash_base))) {                     
                                       
{code}

A path that ended in "Currently" could trigger this check right now.

> Wrong path when deleting through fuse-dfs a file which already exists in trash
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-7162
>                 URL: https://issues.apache.org/jira/browse/HDFS-7162
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: fuse-dfs
>    Affects Versions: 3.0.0, 2.5.1
>            Reporter: Chengbing Liu
>            Assignee: Chengbing Liu
>         Attachments: HDFS-7162.patch
>
>
> HDFS-4913 lacks a slash in renaming existing trash file. Very small fix for 
> this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to