[
https://issues.apache.org/jira/browse/HDFS-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160998#comment-14160998
]
Colin Patrick McCabe commented on HDFS-7189:
--------------------------------------------
bq. \[is adding unwrapRemoteException to getStoragePolicies\] a bug fix?
Hmm. Good question. I looked into this a little more, and I think I will skip
adding new invocations of {{unwrapRemoteException}} in this patch. The
unwrapping is only needed when the NameNode actually throws one of those
exceptions, but I don't think that can happen for {{getStoragePolicies}} or
many of the other functions here. Plus, adding that stuff muddies the
waters... it would be better to do it in a separate patch than to combine it
with this one.
bq. Removing checkOpen(); in delete is intentional ?
Ah, but the one-argument version of {{delete}} now calls another override of
the function, which then calls {{checkOpen}}. So it should be OK.
bq. Is this intentional... calling trace getCurrentEditLogTxid though its in
getInotifyEventStream ... I suppose it is given it actually does do
getCurrentEditLogTxid
I think we should, since we want to know about this source of activity. We
want to know what the performance impact of inotify is.
I also fixed a findbugs warning. Reposting....
> Add trace spans for DFSClient metadata operations
> -------------------------------------------------
>
> Key: HDFS-7189
> URL: https://issues.apache.org/jira/browse/HDFS-7189
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 2.7.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-7189.001.patch
>
>
> We should add trace spans for DFSClient metadata operations. For example,
> {{DFSClient#rename}} should have a trace span, etc. etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
