[
https://issues.apache.org/jira/browse/HDFS-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170766#comment-14170766
]
Hadoop QA commented on HDFS-7242:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12674720/HDFS-7242.001.patch
against trunk revision 5faaba0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing
The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8418//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8418//console
This message is automatically generated.
> Code improvement for FSN#checkUnreadableBySuperuser
> ---------------------------------------------------
>
> Key: HDFS-7242
> URL: https://issues.apache.org/jira/browse/HDFS-7242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.6.0
> Reporter: Yi Liu
> Assignee: Yi Liu
> Priority: Minor
> Attachments: HDFS-7242.001.patch
>
>
> _checkUnreadableBySuperuser_ is to check whether super user can access
> specific path. The code logic is not efficient. It does iteration check for
> all user, actually we just need to check _super user_ and can save few cpu
> cycle.
> {code}
> private void checkUnreadableBySuperuser(FSPermissionChecker pc,
> INode inode, int snapshotId)
> throws IOException {
> for (XAttr xattr : dir.getXAttrs(inode, snapshotId)) {
> if (XAttrHelper.getPrefixName(xattr).
> equals(SECURITY_XATTR_UNREADABLE_BY_SUPERUSER)) {
> if (pc.isSuperUser()) {
> throw new AccessControlException("Access is denied for " +
> pc.getUser() + " since the superuser is not allowed to " +
> "perform this operation.");
> }
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
