[
https://issues.apache.org/jira/browse/HDFS-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawson Choong updated HDFS-7190:
--------------------------------
Status: Patch Available (was: Open)
> Bad use of Preconditions in startFileInternal()
> -----------------------------------------------
>
> Key: HDFS-7190
> URL: https://issues.apache.org/jira/browse/HDFS-7190
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.6.0
> Reporter: Konstantin Shvachko
> Assignee: Dawson Choong
> Labels: newbie
> Attachments: HDFS-7190.patch
>
>
> The following precondition is in the middle of startFileInternal()
> {code}
> feInfo = new FileEncryptionInfo(suite, version,
> ....
> Preconditions.checkNotNull(feInfo);
> {code}
> Preconditions are recommended to be used in the beginning of the method.
> In this case the check is no-op anyways, because the variable has just been
> constructed.
> Should be just removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
