[
https://issues.apache.org/jira/browse/HDFS-7165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177400#comment-14177400
]
Andrew Wang commented on HDFS-7165:
-----------------------------------
Almost there, thanks for revving Zhe.
* In ClientProtocol#getStats, it mentions "total used space of the block pool",
and I see that being set in HeartbeatManager, but AFAICT it's dropped in the PB
layer on the server side. If it's not being used, let's remove it. If not, it's
a compat issue to insert something at an already-being-used index of the stats
array.
* TestMissingBlocksAlert still has a whitespace-only change. Line 79-80 were
deleted.
* TestUnderReplicatedBlockQueues, the extend:
{code}
public class TestUnderReplicatedBlockQueues extends Assert {
{code}
We should not "extends Assert" in test cases. Instead, let's add static imports
on the various Asserts being used. Let's undo the assertInLevel changes too,
using {{fail}} as it was before was good.
> Separate block metrics for files with replication count 1
> ---------------------------------------------------------
>
> Key: HDFS-7165
> URL: https://issues.apache.org/jira/browse/HDFS-7165
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Andrew Wang
> Assignee: Zhe Zhang
> Attachments: HDFS-7165-20141003-v1.patch,
> HDFS-7165-20141009-v1.patch, HDFS-7165-20141010-v1.patch,
> HDFS-7165-20141015-v1.patch
>
>
> We see a lot of escalations because someone has written teragen output with a
> replication factor of 1, a DN goes down, and a bunch of missing blocks show
> up. These are normally false positives, since teragen output is disposable,
> and generally speaking, users should understand this is true for all repl=1
> files.
> It'd be nice to be able to separate out these repl=1 missing blocks from
> missing blocks with higher replication factors..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
