[
https://issues.apache.org/jira/browse/HDFS-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181780#comment-14181780
]
Colin Patrick McCabe commented on HDFS-7223:
--------------------------------------------
Thanks, Masatake. Findbugs warning is HDFS-7227-- not related to this patch.
In WritableRpcEngine.java, we just do this:
{code}
traceScope = Trace.startSpan(method.getName());
{code}
but in ProtobufRpcEngine.java, we do this:
{code}
traceScope = Trace.startSpan(methodToTraceString(method));
{code}
It seems like we should harmonize these so they do the same thing.
Perhaps we could move {{methodToTraceString}} into {{RpcClientUtil.java}} as a
static method, so both call sites could use it?
+1 once that's addressed
> Tracing span description of IPC client is too long
> --------------------------------------------------
>
> Key: HDFS-7223
> URL: https://issues.apache.org/jira/browse/HDFS-7223
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Priority: Minor
> Attachments: HDFS-7223-0.patch, HDFS-7223-1.patch
>
>
> Current span description for IPC call is too long.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
