Feng Shu <tuma...@163.com> writes:

I have find you update wip-orthanc-integration and
his-client-utils/develop, some suggestion:

1. 

Suggest do not conside po and pot files before this branch merge, po and
pot files will let PR too big, hard to review. After merge, I can update
pot and po file with the help of po-export and other scripts.



2. 


    label = fields.Char(
           "Label", required=True, readonly=True, help="Label for server (eg., 
remote1)")
          "Label", required=True, readonly=True, help=gettext("Label for server 
(eg., remote)"))


gettext is useless, should remove.


3.  

   handle all warn of his/lint.sh, you can try autopep8.sh


4. 

   suggest clean git history before merge.


Reply via email to