On 07/07/2015 08:52 AM, Paul Bonser wrote:
According to the Go code review guidelines, the idiomatic way to have
initialisms in identifiers is to have all the letters be capitalized:
https://github.com/golang/go/wiki/CodeReviewComments#initialisms
Heka is approaching 3 years old at this point, a number of features of the
coding style were made before the Go idioms were so clearly spelled out so,
yes, there's some inconsistency in the code base.
Is this a thing which might be considered for Heka, to follow Go
community conventions? In this case it would mean renaming HttpInput to
HTTPInput, TcpInput to TCPInput, UdpInput to UDPInput, etc.
I'm not 100% against it, but it falls pretty low on my priority list re: where
our limited time improving Heka should be spent.
Interestingly AMQPInput is already following the convention, so adopting
the standard would make it more consistent.
Part of why I'm asking is because I'm writing some plugins myself and
I'm currently torn between following the Go convention and following the
Heka convention.
Use the Go convention.
-r
_______________________________________________
Heka mailing list
[email protected]
https://mail.mozilla.org/listinfo/heka
