Hi Jiri,

> Hi Dominik,
> 
> I am afraid that my networking changes will render your patch irrelevant. In 
> my
> branch I have re-implemented the internet checksum in a different way and
> dropped the CRC, since it's not needed anywhere at the moment. 

Well, I need it, that's why I moved it.

> Also note that
> the method Lukas uses for CRC32 computation is very naive - it is slow and 
> also,
> for some unknown reason, endian-dependent. There exist table-based methods 
> which
> can compute CRC32 with one table lookup per input byte, rather than 
> calculating
> bit by bit, and they are endian-independent, I believe.

Well, I can try to reimplement the CRC. Or is anyone working on it (or is going 
to)?

> 
> Cheers,
> Jiri
> 
> 
> Dominik Taborsky wrote:
> > Hi everyone,
> > 
> > Since checksum and CRC32 computations are fairly common, I have made a patch
> to
> > move those two from libnet to libc. There are no other changes than moving 4
> > functions from uspace/lib/net/generic/net_checksum.{c, h} to checksum.{c,h}
> in
> > libc.
> > 
> > Also, I have been told networking is under refactoring, so Jiri, any
> comments?
> > 
> > Regards,
> > 
> > Dominik Taborsky
> > 
> > 
> 
> _______________________________________________
> HelenOS-devel mailing list
> [email protected]
> http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
> 
> 
> 

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel

Reply via email to