Hi, On Tue, Mar 20, 2012 at 2:40 AM, Martin Decky <[email protected]> wrote: > > The porting of GCC might be really quite similar to porting binutils, > therefore I suggest that you read the binutils port maintenance guide [1] > and perhaps also the relevant emails in the archive of this mailing list > from Petr Koupy ([email protected]) from last year's GSoC. They might > give you some idea what problems Petr had to solve when porting binutils. > > [1] > http://trac.helenos.org/wiki/**BinutilsMaintenance<http://trac.helenos.org/wiki/BinutilsMaintenance>
Thank you for the pointers. They will surely help a lot. I have attached a patch of the touch.c file, where i have added -c option. >> > > I'll use this opportunity to improve the touch.c based on your patch, but > in a larger extent. Do you give us the permission to integrate your patch > into our source tree under the BSD license? I will be the happiest person if any part of my work is integrated in HelenOS source tree under the BSD license :-) > Regarding your patch, it is mostly OK. I have only some minor comments: > > * You should have altered the initial TODO comment in touch.c, too. You > have implemented one of the TODO items. > Oh, i missed that in hurry! > * Line continuations (when forced to break the line when reaching 80 > characters) should be indented by four spaces. I admit that the > original touch.c did not follow this rule perfectly. > Thanks for letting me know of this. I will take care of it in future. > * Identifiers should be named in a better way. Instead of "opt_ind" > (too similar to "optind") you should rather use "longind". Instead of > "cflag" you should rather use "no_create". > Yes, that makes sense to name identifiers in a better way. I accept it was not very good, and "no_create" & "longind" should rather be used. I had gone through the source code in uspace/app/bdsh/cmds/modules and found "opt_ind" used almost everywhere. So, i just replicated the format used. They should also be replaced by "longind", i think (I guess code refactoring is then another issue, which is of little priority for now in this big project). Again, thank you for letting me know of these little problems. I can now avoid them now in future! Thanks, Vivek Prakash
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
