Hi Vojta,
On Thu, Apr 5, 2012 at 5:12 PM, Vojtech Horky <[email protected]>wrote: > Hi Ketan, > thanks for the patch. I inlined some comments below but the current > version of the patch looks good to me and I will integrate it into > mainline. Though, it make take some time. Once again, thanks. > > No problem :-) > Dne 5. dubna 2012 13:07 Ketan Singh <[email protected]> napsal(a): > >> > inside the libc ( I think that should be its proper place. ). Also the > >> > changes in chdir are minimal now ( It sets the pwd parameter. ). > >> > Regarding the second issue ( '-' could be a valid filename ), we have > to > >> > compromise somewhere. This is similar to the case of 'cd ..' . I could > >> > implement something like 'cd ...' to maintain the format and forbid > the > >> > user > >> Probably I didn't express myself clearly. My point is that if we add > >> such behavior, we must provide way to override it. For example, 'cd -' > >> to switch to previous directory and 'cd -- -' to switch to directory > >> '-' (taking '--' as way to end option specification). Using different > >> syntax is not a solution. > > > > > > I have implemented the override feature in the new patch. Please have a > look > > at it. If you find any problems/ suggestions please let me know. > There is just one little thing I might change. Maybe the -- can be > used with any directory. I believe that this could be fixed with 2 > lines of code ;-). > Yeah, I removed the first comparison with "-" for second argument and now it overrides for any directory. I have attached the updated patch for the same. Also, I had some questions regarding the GSoC application: 1. I am interested in any of the following projects: - Support PAE on ia32 - Graceful System Shutdown - Improve hash table implementation Can I write them in one single proposal or should submit separate proposals? 2. What chances do I have in these kernel projects? Or should I focus more on app projects. Actually I had an Advanced OS course recently, so all these concepts are fresh right now. Thank you for your time and suggestions. Cheers, Ketan _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/cgi-bin/listinfo/helenos-devel >
cd_with_override.patch
Description: Binary data
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
