2012/4/5 Tobias Börtitz <[email protected]>: > So here comes the patch again. >
Mmmm, the patch looks good but what I don't like is the end result, I mean, now we have the following functions: do_copy() do_copy_file() do_copy_dir() copy_file() Looks like a crazy thing, in fact, it is harder to read than before. This is my opinion... I know I'm the one to blame for this mess. What I suggest to do: keep the old do_copy() function and apply the "interactive" patch to it; Than later I could (or you Tobias, if you want) rewrite the do_copy() function in a non-crazy form. I even noticed one nit, do_copy() returns an int64_t, no need to do that it can be replaced with a simple "int". -- -------------------- Maurizio Lombardi _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
