Hi Tobias, sorry for my late reply and thanks for the improvements in your patch.
2012/4/11 Tobias Börtitz <[email protected]>: > Hm you are right. So I decided to distinguish between delimiters > and punctuation marks because the caret has to stop right before a delimiter > but exactly on the punctuation mark. I added functions to check whether the > given s-point is 1) a delimiter or 2) a punctuation mark. This works well for me. Thanks. > >> One more thing, Tobias - please, do put space between "if" and the >> condition. > > Yes I saw this right after submitting the patch. So this is fixed now. > > Please have a look at the improved patch and let me know whether there are > any more concerns. I applied your patch in my misc branch and I will merge it to mainline probably next week. I changed few minor things: * Removed redundant returns at the end of void functions. * In pt_is_word_beginning() the bit operations were replaced with logical ones (I guess that was a typo). * In pt_is_delimiter/punctuation() I replaced the direct access to first byte with str_decode() for better UTF-8 safety. * The word deletion (ctrl-w) can happen only when there is no selection active. Otherwise, the behaviour was a bit counter-intuitive (very different results when single word and two words were selected). Thanks once more. - Vojta > > Tobias. >> >> >> Cheers, >> - Vojta >> >> > >> > Regards, >> > Martin Sucha >> > >> > >> > _______________________________________________ >> > HelenOS-devel mailing list >> > [email protected] >> > http://lists.modry.cz/cgi-bin/listinfo/helenos-devel >> >> _______________________________________________ >> HelenOS-devel mailing list >> [email protected] >> http://lists.modry.cz/cgi-bin/listinfo/helenos-devel > > > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/cgi-bin/listinfo/helenos-devel > _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
