Hello Sandeep Kumar.
I am new to HelenOs and this is going to be my first open source
contribution.
I want to work on a small ticket/bug to get the things started so
i've chosen to work on ticket #50. I have even fixed a part of the
ticket and is attaching the diff for the same (the diff is over revno
1517). I've completed the first point of ticket #50.
Thank you for your contribution and sorry for a late reply.
In essence your patch seems to do the trick, thanks again! I will try my
best to push the functionality into our mainline branch based on your
patch in a few days. I will not use your patch directly, though, because
of a few nits (see below).
Please provide me feedback on whether i am doing it the right way or
not. It will really help me getting started :)
You should stick more closely to the HelenOS coding style [1]. The
formal rules are perhaps not so important than simply respecting the
style of the existing code surrounding your modifications. For example,
do not use C++ style comments and do not forget the space between "for"
and the parenthesis.
Also, I would personally use more verbose variable names than "mml" and
"mml_tmp". But this is really very subjective.
[1] http://www.helenos.org/cstyle
Best regards
Martin Decky
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
