On 07/20/2012 05:36 PM, Jiří Zárevúcky wrote: > On 20 July 2012 16:55, Jiří Zárevúcky <[email protected]> wrote: >> On 20 July 2012 16:36, Jakub Jermar <[email protected]> wrote: >>> >>> In your patch, why don't you simply add size and align in area_grow(), >>> just as you do for the new areas? >>> >> >> I wanted to avoid requesting more pages than necessary, but now that I >> think about it, it probably doesn't really matter, does it? >> What I find peculiar though is that growing the area always creates a >> new free block, even if the previous block is free. >> Seems to me like a completely unnecessary fragmentation. > > There, my final iteration. > I went back to just adding the alignment size regardless of whether > it's necessary. Shouldn't matter much. > What I kept is allocation directly after grow, and I modified > area_grow() to append to the last block if possible. > Feel free to ignore that last part if you wish, it just seemed to me > like the right thing to do there.
The patch looks good to me. If there are no objections, I would merge it. Jakub _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
