Resending to helenos-devel@ for additional feedback, if any... -------- Original Message -------- Subject: Re: rtc-clock driver code review Date: Thu, 23 Aug 2012 14:26:14 +0200 From: Maurizio Lombardi <[email protected]> To: Jakub Jermar <[email protected]>
Hi Jakub, this is a report about the current status of the rtc branch. > - do not use uint32_t IO base address, preferably ioport8_t * or > uintptr_t or void * Fixed, it now uses ioport8_t* The ns8250 driver needs to be fixed too 'cause it has the same problem. > - put boottime to soft state Fixed. > - off-lining support (via devctl offline) Done but you can not offline the device if a client is connected to it. e.g. if top is running you cannot offline the rtc driver. > - double wait for IPC answers (consider using async_forget()) Fixed, I use async_forget() now. > - consider time_* naming scheme, use underscores These are the prototypes of the time functions under lib/c/include/sys/time.h --------------- extern void tv_add(struct timeval *tv, suseconds_t usecs); extern suseconds_t tv_sub(struct timeval *tv1, struct timeval *tv2); extern int tv_gt(struct timeval *tv1, struct timeval *tv2); extern int tv_gteq(struct timeval *tv1, struct timeval *tv2); extern int gettimeofday(struct timeval *tv, struct timezone *tz); extern int getuptime(struct timeval *tv); extern void udelay(useconds_t); extern time_t mktime(struct tm *tm); extern int time_utc2tm(const time_t time, struct tm *result); extern int time_utc2str(const time_t time, char *buf); extern void time_tm2str(const struct tm *timeptr, char *buf); extern int time_local2tm(const time_t time, struct tm *result); extern int time_local2str(const time_t time, char *buf); -------------- > - cstyle in rtc read Fixed > - consider being port IO / memory mapped IO neutral mmmm, I don't remember what the problem was with the current implementation... Can you refresh my mind please? -- -------------------- Maurizio Lombardi _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
