Hi, Jana,
2013/2/15 Jana Rapava <[email protected]>:
> Hi,
> I'm working on network autoconfiguration in HelenOS for my bachelor thesis,
> and would like to put the code on launchpad.
I was a bit impatient to see how the autoconfiguration would work so I
checked out your branch. It looks I will need to wait a bit longer
;-).

However, I noticed that you have a lot of debugging prints there using
plain printf for that. We have a simple logging system available [1]
so you may consider using it instead. It offers printing at several
verbosity levels and allows you to create hierarchical log-groups.
Downside is that it prints the logs to the file instead of the screen
(stdout) but it is trivial to change that in libc. Then, you would not
need to pass the verbose flag to each of your functions.

By the way, there is getopt implementation in libc which may simplify
your arguments handling a bit. And AFAIK stdout is line-buffered, thus
the flush() is not necessary. Not that it would cause any harm.

- Vojta

[1] http://trac.helenos.org/wiki/Logging

> Should I create a separate project, or import my branch here
> ( https://code.launchpad.net/helenos )?
> Thanks,
> Jana Rapava
>
> _______________________________________________
> HelenOS-devel mailing list
> [email protected]
> http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
>

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel

Reply via email to