Hi Zbigniew,

2013/4/3 Zbigniew Halas <[email protected]>

> On Tuesday 02 April 2013 19:41:02 Jakub Jermar wrote:
> > > Then boot HelenOS and enjoy Python!
> >
> > and Python I enjoyed! Thanks for working on this.
>
I concur. Nice job. I have no problem building the Python using the
instructions you provided.



> Welcome. I guess it's time to work on something more serious now ;)
>
> > How do you get the new binary and the python2.7 library to the
> > initrd.img? For me, this was not very convenient as I had to prevent
> > make in the boot subtree from cleaning up uspace/dist first.
>
> I made some nasty ad-hoc hack to the Makefile.
>
I think we should introduce some target to do just this - repack the
uspace/dist and produce the final image without cleaning the directory
first. I think I will hit the same problem soon with my effort around
porting GCC.



>
> > I used the new 4.8 toolchain to build Python and it produced a great
> > deal of warnings, fortunately the compilation completed just fine.
>
> Yeah, but it actually has almost all possible warnings enabled and it's not
> much different from Python compilation for Linux with the same flags,
> although
> probably there are some extra warnings worth fixing.
>
Just a footnote: compiling with GCC 4.7.2 produce warnings for almost each
file as well.


 > The patches look reasonably small and the overall amount of changes is
> > pretty small too, which is nice. Unless someone has some serious
> > concerns, I would like to integrate this.
>
> Great, thank you!
>
The patches look good to me too. I didn't know that the floating point
constants are actually built-ins like this - it renders my approach in the
gcc-port branch [1] quite naive ;-).

I also looked at the changes you made to the Python source code and I am
really surprised that the diff is so small. Moreover, half of the changes
came from the need to rename posix_ to pyposix_. By the way, I already
removed this posix_ prefixing in libposix in my GCC branch so in the future
such problems would not need to be solved.

Thanks!

- Vojta


[1] https://code.launchpad.net/~vojtech-horky/helenos/gcc-port


>
> Zbigniew
>
> _______________________________________________
> HelenOS-devel mailing list
> [email protected]
> http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
>
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel

Reply via email to