Hello, František. Dne 2. srpna 2013 11:02 frantisek haas <[email protected]> napsal(a):
> I hope that the way I made the patch "bzr diff > patch.diff" is the > correct way to make patches against last revision (1903 in my case). I'm > still getting used to bzr. > Yes. Other option is to create a merge directive if your patch is supposed to span across more commits. Regarding the #91: The code formatting looks okay to me. The patch does not compile on all architectures (you can use ./tools/check.sh to compile HelenOS for all supported targets) - it seems to me that using %d for sysarg is at fault. I was not able to use the pager for some commands. For example, running pager followed by test slab2 would not invoke the pager correctly (in QEMU on ia32). It would be nice to show some prompt to tell the user that the pager took over. Also, I think that the keys used to show next page should be consumed by the pager, that is that they do not appear as input once the kcon prompt is displayed. Cheers, - Vojta > > Regards, > Frantisek Haas > > > 2013/8/2 frantisek haas <[email protected]> > >> Fixed -). My first mail got moderated since I was not yet a mailing list >> member and then I forget to attach it to the second resent mail. >> >> Regards, >> Frantisek Haas >> >> >> >> 2013/8/2 Vojtech Horky <[email protected]> >> >>> Hello, František. >>> >>> Dne 2. srpna 2013 6:09 frantisek haas <[email protected]>napsal(a): >>> >>> Zdravim, >>>> >>>> Jmenuju se Frantisek Haas, studuju softwarove systemy na MFF a rad bych >>>> se zapojil do vyvoje HelenOS. Budu podavat prihlasku do programu SOCIS >>>> 2013. >>>> >>>> V priloze posilam navrh na ticket #91. Jedna se o utilitu pager do >>>> kconsole, ktere se da nastavit pocet radku a po jejich dosazeni prestane >>>> vypisovat vystup az do stisknuti klavesy. Prestanou se vypisovat pouze >>>> prikazy obsluhovane vlaknem kconsole. Doufam, ze se mi primerene povedlo >>>> dodrzet stabni kulturu a implementovat to rozumne. Budu rad za pripominky. >>>> >>> I do not see any attachments in this e-mail :-). >>> >>> And, please, use English in this mailing-list (despite the Czech domain >>> and Czech-speaking admins). Thanks a lot. >>> >>> Cheers, >>> - Vojta Horký >>> >>> >>>> >>>> S pozdravem, >>>> FH >>>> >>>> P.S. >>>> Do mailing listu cz nebo en? >>>> >>>> _______________________________________________ >>>> HelenOS-devel mailing list >>>> [email protected] >>>> http://lists.modry.cz/listinfo/helenos-devel >>>> >>>> >>> >>> _______________________________________________ >>> HelenOS-devel mailing list >>> [email protected] >>> http://lists.modry.cz/listinfo/helenos-devel >>> >>> >> > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/listinfo/helenos-devel > >
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
