Hi all,
I found a memory leak in driver.c. I'm using a software tool to catch, and
I already found some errors like this.
Can I send a mail for each?

Regards,
Manuele
=== modified file 'uspace/lib/drv/generic/driver.c'
--- uspace/lib/drv/generic/driver.c	2015-09-30 17:47:41 +0000
+++ uspace/lib/drv/generic/driver.c	2016-03-16 08:32:25 +0000
@@ -120,19 +120,18 @@
 	devman_handle_t dev_handle = IPC_GET_ARG1(*icall);
 	devman_handle_t parent_fun_handle = IPC_GET_ARG2(*icall);
 	
+	char *dev_name = NULL;
+	int rc = async_data_write_accept((void **) &dev_name, true, 0, 0, 0, 0);
+	if (rc != EOK) {
+		async_answer_0(iid, rc);
+		return;
+	}
+
 	ddf_dev_t *dev = create_device();
-	
+
 	/* Add one reference that will be dropped by driver_dev_remove() */
 	dev_add_ref(dev);
 	dev->handle = dev_handle;
-	
-	char *dev_name = NULL;
-	int rc = async_data_write_accept((void **) &dev_name, true, 0, 0, 0, 0);
-	if (rc != EOK) {
-		async_answer_0(iid, rc);
-		return;
-	}
-	
 	dev->name = dev_name;
 	
 	/*

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to